Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19006 )
Change subject: IMPALA-8770: Support building Docker images on Redhat-based distributions ...................................................................... Patch Set 13: Code-Review+2 (2 comments) LGTM, with just a comment and a future suggestion. http://gerrit.cloudera.org:8080/#/c/19006/13/docker/CMakeLists.txt File docker/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19006/13/docker/CMakeLists.txt@60 PS13, Line 60: set(DISTRO_BASE_IMAGE "$ENV{IMPALA_REDHAT7_DOCKER_BASE}") Maybe add a comment here stating that leaving QUICKSTART_BASE_IMAGE unset here is intentional (because Quickstart is supported only on Ubuntu)? http://gerrit.cloudera.org:8080/#/c/19006/13/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/19006/13/docker/daemon_entrypoint.sh@32 PS13, Line 32: This can get more detailed if there are specific steps : # for specific versions, but at the moment the distribution : # is all we need. : DISTRIBUTION=Unknown : if [[ -f /etc/redhat-release ]]; then : echo "Identified Redhat image." : DISTRIBUTION=Redhat : else : source /etc/lsb-release : if [[ $DISTRIB_ID == Ubuntu ]]; then : echo "Identified Ubuntu image." : DISTRIBUTION=Ubuntu : fi : fi : : if [[ $DISTRIBUTION == Unknown ]]; then : echo "ERROR: Did not detect supported distribution." : echo "Only Ubuntu and Redhat-based distributions are supported." : exit 1 : fi At the risk of overgeneralizing: could be worth extracting such snippets into a distro-detector shell fragment that could be sourced in various scripts, even if in a later iteration? -- To view, visit http://gerrit.cloudera.org:8080/19006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibaff2560ef971ac2c2231a8e43921164ea1d2f4d Gerrit-Change-Number: 19006 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Tue, 04 Oct 2022 21:06:41 +0000 Gerrit-HasComments: Yes
