Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19087 )
Change subject: IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close() ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19087/4/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/19087/4/be/src/exec/topn-node.cc@701 PS4, Line 701: for (auto& entry : partition_heaps_) { > Looking at the default destructor for TopNNode::Heap::~Heap(), it will do e Thanks for the confirmation. My concern is that it could have a potential leaking issue and very difficult to find if the Close() implementation changes in the future that needs an explicit calling. But I agree that it should be safe now, and even not calling any Close() for the Heap -- To view, visit http://gerrit.cloudera.org:8080/19087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf45b6ef777f68e1843c076a935e4189acc6990b Gerrit-Change-Number: 19087 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 04:59:01 +0000 Gerrit-HasComments: Yes
