Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19095 )
Change subject: IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric ...................................................................... IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric There has been occurrences where an impala backend crash and lead to metric admission-controller.executor-group.num-queries-executing.* goes negative. While we still investigating the exact scenario leading into this negative metric issue, this patch add a DCHECK in AdmissionController::UpdateExecGroupMetric to ensure that such case does not happen in regular nightly tests. Testing: - Run and pass exhaustive test. Change-Id: Icee9ae58d14d69a1548da3eccb51a00a7d727c13 Reviewed-on: http://gerrit.cloudera.org:8080/19095 Reviewed-by: Abhishek Rawat <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admission-controller.cc 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Abhishek Rawat: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icee9ae58d14d69a1548da3eccb51a00a7d727c13 Gerrit-Change-Number: 19095 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
