Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19031 )
Change subject: IMPALA-11634: Provide an option to use Java 11 for docker images ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/19031/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19031/13//COMMIT_MSG@18 PS13, Line 18: Ran a set of dockerized tests wi > nit: looks like an incomplete sentence/paragraph Done http://gerrit.cloudera.org:8080/#/c/19031/13/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/19031/13/docker/daemon_entrypoint.sh@62 PS13, Line 62: if compgen -G "/usr/lib/jvm/java-11-openjdk*" > Ubuntu 16.04 might require checking additional locations or glob names: it I added an error for Ubuntu 16.04 + Java 11, so skipping this. http://gerrit.cloudera.org:8080/#/c/19031/13/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/19031/13/docker/install_os_packages.sh@82 PS13, Line 82: openjdk-11-jre-headless > I'm afraid this won't work on Ubuntu 16.04: the standard repos don't includ Since Ubuntu 16.04 is EOL, I added a check above that errors out for Ubuntu 16.04 + Java 11. -- To view, visit http://gerrit.cloudera.org:8080/19031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc1dbd3f6a2279840218dc1da2b60077e211a328 Gerrit-Change-Number: 19031 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 22:38:43 +0000 Gerrit-HasComments: Yes
