Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )
Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java: http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@32 PS1, Line 32: TAlterTableSetFileFormatParams fileFormatParams = new TAlterTableSetFileFormatParams(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19099/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1057 PS1, Line 1057: refreshedTable = alterTableAddPartitions(tbl, params.getAdd_partition_params(),format); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19099/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/19099/1/tests/metadata/test_ddl.py@648 PS1, Line 648: " flake8: F523 '...'.format(...) has unused arguments at position(s): 1 -- To view, visit http://gerrit.cloudera.org:8080/19099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69 Gerrit-Change-Number: 19099 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:22:48 +0000 Gerrit-HasComments: Yes
