Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 )
Change subject: IMPALA-11628: Switch to reload4j, update slf4j ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > LGTM! > Just curious about the version, saw 1.7.36 is used in some components, is > there a guideline for this or the latest is the always best? 1.7.36 is the last before 2.0. I don't see any obvious problems with 2.0, and 2.0+ was necessary to get later versions of reload4j. I'm mostly relying on testing to see whether there are any issues updating it. -- To view, visit http://gerrit.cloudera.org:8080/19102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5238b9c8247af3e0f4cb05c0b76a75bfee37f5c8 Gerrit-Change-Number: 19102 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 06 Oct 2022 23:42:49 +0000 Gerrit-HasComments: No
