Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 )
Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu table ...................................................................... Patch Set 8: (1 comment) > Patch Set 8: Verified+1 http://gerrit.cloudera.org:8080/#/c/18953/8/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java: http://gerrit.cloudera.org:8080/#/c/18953/8/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java@87 PS8, Line 87: throw new AnalysisException("Duplicate column name: " + colName); > should we also ignore this error when `if not exists` is presented? It's already there, and It works for this situation 'alter table tbl add if not exists columns (b int, b int);', but this might be debatable if the field types were different. e.g.: alter table tbl add if not exists columns (b int, b string); -- To view, visit http://gerrit.cloudera.org:8080/18953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82590e5372e881f2e81d4ed3dd0d32a2d3ddb517 Gerrit-Change-Number: 18953 Gerrit-PatchSet: 8 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 09 Oct 2022 02:27:08 +0000 Gerrit-HasComments: Yes
