Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
......................................................................


Patch Set 4:

> Patch Set 4:
>
> > > Patch Set 3:
>  > >
>  > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/
>  > >
>  > > Is the build server disk space insufficient?
>  >
>  > There are test failures that need to be addressed:
>  > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721
>  > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6414
>  > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17722
>
> I have adjusted the unit test cases.
> But my local environment cannot compile (due to Amazon s3 warehouse problem), 
> According to this 
> document:https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests.

There are other end-to-end test (not just unit test) failures that need to fix, 
e.g. 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721/testReport/junit/query_test.test_queries/TestQueries/test_subquery_protocol__hs2___exec_option____test_replan___1___batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__parquet_none_/

If you can't compile Impala locally, you can't reproduce the failure. It'd be 
nice if you can verify your fix locally first before sending it for review.

Are you still hitting s3 download issues? You might need a VPN to achieve 
better download speed if you are in China. You can also try some steps 
mentioned in IMPALA-9078.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Sun, 09 Oct 2022 23:17:01 +0000
Gerrit-HasComments: No

Reply via email to