Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19092 )
Change subject: IMPALA-10889: Allow extra 1MB for fragment cancellation ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/19092/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19092/1//COMMIT_MSG@11 PS1, Line 11: In this test case, the extra reserved memory after : cancellation is small (<1MB), as seen in logs printing : agg_mem_reserved. Previously the test and query limits were exactly : matched, so any extra reservation would prevent scheduling, causing the : test to frequently time out. nit. Suggest to reword a bit to state the cause first and then the solution. "The test and query limits were exactly matched, so any extra reservation would prevent scheduling, causing the test to frequently time out. With the fix, a 1MB of extra memory is reserved to break the tie thus avoiding the time out. The extra 1MB of memory can be seen in logs printing agg_mem_reserved." http://gerrit.cloudera.org:8080/#/c/19092/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19092/1/tests/custom_cluster/test_executor_groups.py@566 PS1, Line 566: 4gb mem_limit nit. May update to reflect the change. -- To view, visit http://gerrit.cloudera.org:8080/19092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee557ad87d3926589b30d6dcdd850e9af9b3476 Gerrit-Change-Number: 19092 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 10 Oct 2022 13:50:16 +0000 Gerrit-HasComments: Yes
