Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )
Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT ...................................................................... Patch Set 5: Code-Review+1 (1 comment) A minor comment. Let's wait a bit in case Lipenglin has something else too. http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/19099/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java@79 PS5, Line 79: %s Nit: if we're using a StringBuilder, maybe it's cleaner if we add " SET FILEFORMAT " and 'fileFormat' in two calls to sb.append() instead of string formatting. -- To view, visit http://gerrit.cloudera.org:8080/19099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69 Gerrit-Change-Number: 19099 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 10 Oct 2022 14:47:23 +0000 Gerrit-HasComments: Yes
