Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18862 )
Change subject: IMPALA-11485: Pushdown LIMIT through UNION ALL and LEFT/RIGHT OUTER JOIN ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18862/5/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-union.test File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-union.test: http://gerrit.cloudera.org:8080/#/c/18862/5/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-union.test@8 PS5, Line 8: limit 5; > Of course, i will add a test with an OFFSET clause. But, because OFFSET req Oops, you are right, I was confused because of the second paragraph of https://impala.apache.org/docs/build/html/topics/impala_offset.html , so I thought that Impala supports offset without order by (which doesn't really make sense, as Impala has no ordering guarantees without order by) -- To view, visit http://gerrit.cloudera.org:8080/18862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d040c0a98e60639d7ce4b25ecf07a859c8a32c Gerrit-Change-Number: 18862 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 10 Oct 2022 16:13:18 +0000 Gerrit-HasComments: Yes
