Quanlong Huang has uploaded this change for review. (
http://gerrit.cloudera.org:8080/19122
Change subject: IMPALA-11648: validate-java-pom-versions.sh should skip pom.xml
in toolchain
......................................................................
IMPALA-11648: validate-java-pom-versions.sh should skip pom.xml in toolchain
bin/validate-java-pom-versions.sh validates the pom.xml files have
consistent version strings. However, it checks all files in IMPALA_HOME
when building from the tarball. There are some pom.xml files in the
toolchain directory that should be skipped.
This patch modifies the find command used in the script from
find ${IMPALA_HOME} -name pom.xml
to
find ${IMPALA_HOME} -path ${IMPALA_TOOLCHAIN} -prune -o -name pom.xml -print
to list pom.xml files excluding the toolchain directory. More examples
about how to use `find -prune` can be found in this blog:
https://www.theunixschool.com/2012/07/find-command-15-examples-to-exclude.html
Tests:
- Built from the tarball locally
- Modified version strings in some pom.xml files and verified
validate-java-pom-versions.sh is still able to find them.
Change-Id: I55bbd9c85ab0e4a7c054ee2abd70eae0f55c8a01
---
M bin/validate-java-pom-versions.sh
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/19122/1
--
To view, visit http://gerrit.cloudera.org:8080/19122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55bbd9c85ab0e4a7c054ee2abd70eae0f55c8a01
Gerrit-Change-Number: 19122
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
