Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19121 )
Change subject: IMPALA-11617: Pool service should be made aware of processing cost limit ...................................................................... Patch Set 2: (2 comments) Looks very good! http://gerrit.cloudera.org:8080/#/c/19121/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19121/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1840 PS2, Line 1840: x_query_mem_limit() : Long.MAX_VALUE); : // A very good hint. http://gerrit.cloudera.org:8080/#/c/19121/2/fe/src/main/java/org/apache/impala/util/RequestPoolService.java File fe/src/main/java/org/apache/impala/util/RequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/19121/2/fe/src/main/java/org/apache/impala/util/RequestPoolService.java@396 PS2, Line 396: 0L Can we set it to Long.MAX_VALUE by default? In this way, a value of 0 can effectively shut down the executor group (say for maintenance etc). -- To view, visit http://gerrit.cloudera.org:8080/19121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd2a7284eda47a969ef91e4be19f96d2af53449 Gerrit-Change-Number: 19121 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 11 Oct 2022 13:54:29 +0000 Gerrit-HasComments: Yes
