Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19124 )

Change subject: IMPALA-11462: Constant folding causes cast on literal to be lost
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19124/1/tests/query_test/test_queries.py
File tests/query_test/test_queries.py:

http://gerrit.cloudera.org:8080/#/c/19124/1/tests/query_test/test_queries.py@384
PS1, Line 384: class TestConstantFoldingNoTypeLoss(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/19124/1/tests/query_test/test_queries.py@410
PS1, Line 410: -
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/19124/1/tests/query_test/test_queries.py@410
PS1, Line 410:
flake8: E261 at least two spaces before inline comment



--
To view, visit http://gerrit.cloudera.org:8080/19124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f27b204792ef7c59dec5ead363d44ed0c3bc79
Gerrit-Change-Number: 19124
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Tue, 11 Oct 2022 14:10:26 +0000
Gerrit-HasComments: Yes

Reply via email to