Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19104 )
Change subject: IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+ ...................................................................... Patch Set 1: (3 comments) Thanks for the comments http://gerrit.cloudera.org:8080/#/c/19104/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19104/1//COMMIT_MSG@11 PS1, Line 11: unwind_safeness.cc:76] Check failed: !error failed to find symbol dlopen > This line could be surrounded by empty lines to emphasise that it is an exa Done http://gerrit.cloudera.org:8080/#/c/19104/1/be/src/kudu/util/debug/unwind_safeness.cc File be/src/kudu/util/debug/unwind_safeness.cc: http://gerrit.cloudera.org:8080/#/c/19104/1/be/src/kudu/util/debug/unwind_safeness.cc@36 PS1, Line 36: ((decltype(&func_name))g_orig_ ## func_name)(__VA_ARGS__) > To avoid dereferencing a NULL pointer in at least debug builds, we could ch Good point, I added the DCHECK that you recommended. http://gerrit.cloudera.org:8080/#/c/19104/1/be/src/kudu/util/debug/unwind_safeness.cc@77 PS1, Line 77: CHECK(!error) << "failed to find symbol " << sym << ": " << error; > Afaik the error in older systems is reporting the failure of dlsym through Good idea, I added an additional CHECK for ret being non null after this check. -- To view, visit http://gerrit.cloudera.org:8080/19104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaab196b3d669ccc12854a98d0dbfbae2b9b91244 Gerrit-Change-Number: 19104 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 11 Oct 2022 23:08:28 +0000 Gerrit-HasComments: Yes
