Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 )
Change subject: [WIP] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19145/1/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: http://gerrit.cloudera.org:8080/#/c/19145/1/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@215 PS1, Line 215: partitionSpec_ != null && !(table_ instanceof IcebergTable) ? partitionSpec_.getPartitionSpecKeyValues() : null, line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/19145/1/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@279 PS1, Line 279: throw new AnalysisException("PARTITION clause is not supported for Iceberg tables."); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19145/1/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@287 PS1, Line 287: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19145/1/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@295 PS1, Line 295: } else if (fileFormat.toUpperCase().equals("PARQ") || fileFormat.toUpperCase().equals("PARQUET")) { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/19145/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19145/1/tests/query_test/test_iceberg.py@792 PS1, Line 792: @ flake8: E301 expected 1 blank line, found 0 -- To view, visit http://gerrit.cloudera.org:8080/19145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb Gerrit-Change-Number: 19145 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 17 Oct 2022 07:20:22 +0000 Gerrit-HasComments: Yes
