Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19143 )
Change subject: IMPALA-11420: [DOCS] Document CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES syntax ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19143/2/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/19143/2/docs/topics/impala_alter_view.xml@73 PS2, Line 73: property_name = property_value, ... Could you change this to the following format? 'name'='value'[, 'name'='value' ...] Also wrap the name and value with <varname>. So it's consistent with the ALTER_TABLE doc: https://impala.apache.org/docs/build/html/topics/impala_alter_table.html http://gerrit.cloudera.org:8080/#/c/19143/2/docs/topics/impala_alter_view.xml@76 PS2, Line 76: property_name Please wrap this with <varname></varname> and single quotes. http://gerrit.cloudera.org:8080/#/c/19143/2/docs/topics/impala_create_view.xml File docs/topics/impala_create_view.xml: http://gerrit.cloudera.org:8080/#/c/19143/2/docs/topics/impala_create_view.xml@64 PS2, Line 64: property_name = property_value Please wrap the two variables with <varname></varname> and single quotes. -- To view, visit http://gerrit.cloudera.org:8080/19143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief1d6bb525ba85a58b8123a0cb712d83523daaec Gerrit-Change-Number: 19143 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Shajini Thayasingh <[email protected]> Gerrit-Comment-Date: Mon, 17 Oct 2022 10:38:06 +0000 Gerrit-HasComments: Yes
