Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19110 )
Change subject: IMPALA-11629: Support for huawei OBS FileSystem ...................................................................... Patch Set 3: (3 comments) Thank you for the change. Looks good to me. Only some minor comments. http://gerrit.cloudera.org:8080/#/c/19110/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19110/3//COMMIT_MSG@10 PS3, Line 10: The implementation is similar to other remote FileSystems. Would be good to also mention the new added start option num_obs_io_threads in the commit message. http://gerrit.cloudera.org:8080/#/c/19110/3//COMMIT_MSG@12 PS3, Line 12: Testing: Do we need to consider running existing testcases or test data using the huawei OBS as an option? http://gerrit.cloudera.org:8080/#/c/19110/3/java/executor-deps/pom.xml File java/executor-deps/pom.xml: http://gerrit.cloudera.org:8080/#/c/19110/3/java/executor-deps/pom.xml@226 PS3, Line 226: <version>3.1.1-hw-42</version> Would be better to have a variable for version control like ${cos.version} and ${ozone.version}. -- To view, visit http://gerrit.cloudera.org:8080/19110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1 Gerrit-Change-Number: 19110 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 17 Oct 2022 16:38:27 +0000 Gerrit-HasComments: Yes
