[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 )
Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Those changes look good to me! http://gerrit.cloudera.org:8080/#/c/19043/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19043/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@471 PS2, Line 471: getDefaultPartitionSpec > Seems like we can't retrieve the default partition spec for a snapshot: In our scenario, the Impala users are always querying a half hour or more ago(FOR SYSTEM_VERSION AS OF ...), because some data need to be transferred from kudu to iceberg and the action to switch the VIEW structure must be atomic(it is a complicated switching process), but actually don't really change the partition spec very often. So I agree that and it makes sense. -- To view, visit http://gerrit.cloudera.org:8080/19043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb883a28602bb68cf4f61e57cdd691605045ac5 Gerrit-Change-Number: 19043 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 18 Oct 2022 13:21:34 +0000 Gerrit-HasComments: Yes
