[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 )
Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files ...................................................................... Patch Set 2: (3 comments) Thanks for comments! http://gerrit.cloudera.org:8080/#/c/19150/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19150/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@730 PS1, Line 730: i > shouldn't we add an else branch? Done. Although An iceberg partition does not have datafile, then delete file is meaningless. But counting num_files and file_size_in_bytes does make sense. http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@24 PS1, Line 24: $NAMENODE/ > Probably $WAREHOUSE_LOCATION_PREFIX is better I noticed that https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test#L50 still continues to use the $NAMENODE, which is different from https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test#L142. $NAMENODE should be 'hdfs://localhost:20500', but ' $WAREHOUSE_LOCATION_PREFIX' may be null because the environment variable WAREHOUSE_LOCATION_PREFIX is not be set? http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test: http://gerrit.cloudera.org:8080/#/c/19150/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test@30 PS1, Line 30: 3, > Can we always return a valid #ROWS for Iceberg tables? Done. We can get num_rows from Iceberg Partition Stats. For v2 meta, it will be accurate after IMPALA-11516 -- To view, visit http://gerrit.cloudera.org:8080/19150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I110e5e13cec3aa898f115e1ed795ce98e68ef06c Gerrit-Change-Number: 19150 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Oct 2022 09:08:12 +0000 Gerrit-HasComments: Yes
