Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 )
Change subject: IMPALA-10436: Support storage handler privileges for external Kudu table creation ...................................................................... Patch Set 9: (1 comment) Hi all, I have slightly revised the patch according to Csaba's comment in the previous iteration. Let me know if you have any other suggestion. I also added some additional test cases in test_ranger.py to show that statements like the following won't result in the grantee being granted the rwstorage privilege on the resource if the resource is a database or a table (since the privilege of rwstorage is not well-defined with respect to either a database or a table). 1. grant rwstorage on database functional to user non_owner. 2. grant rwstorage on table functional.alltypes to user non_owner. http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG@29 PS5, Line 29: > Can you also add a few negative tests, where there is a * in the privilege? Sure. In the next patch I will add some negative tests in fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java. -- To view, visit http://gerrit.cloudera.org:8080/17640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7936e1d8c48696169f7ad7ad92abe44a26eea3c4 Gerrit-Change-Number: 17640 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 19 Oct 2022 23:42:10 +0000 Gerrit-HasComments: Yes
