Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 )
Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable ...................................................................... Patch Set 5: (3 comments) This looks good, I have a few nits only. http://gerrit.cloudera.org:8080/#/c/19105/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19105/5//COMMIT_MSG@9 PS5, Line 9: Currently max tries for connecting to coordinator is hard coded to 4 Maybe rewrite this paragraph to be about the change: "Make the max tries when connecting to coordinator a configurable option..." http://gerrit.cloudera.org:8080/#/c/19105/5//COMMIT_MSG@20 PS5, Line 20: impala coordinator daemon, verified that impala-shell connect to Nit: "connects" http://gerrit.cloudera.org:8080/#/c/19105/5/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/19105/5/shell/option_parser.py@282 PS5, Line 282: parser.add_option("--connect_max_tries", type="int", Nit: maybe slightly clearer: "Maximum number of times that an idempotent RPC connection to the Impala coordinator will be retried in hs2-http mode." -- To view, visit http://gerrit.cloudera.org:8080/19105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f7caeb91a69e71a38689785fb1636094295fdb1 Gerrit-Change-Number: 19105 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Oct 2022 23:57:22 +0000 Gerrit-HasComments: Yes
