Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 )
Change subject: IMPALA-10436: Support storage handler privileges for external Kudu table creation ...................................................................... Patch Set 12: (2 comments) Hi all, I fixed the 2 failed FE tests identified in previous tests. I also added a code comment regarding how the tests are fixed. Hopefully this time the patch could pass those 2 tests. I have verified locally that those 2 tests are successful in my development environment for Impala. http://gerrit.cloudera.org:8080/#/c/17640/12/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17640/12/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@1028 PS12, Line 1028: // We exclude TPrivilegeLevel.RWSTORAGE because we do not ask Ranger service to grant : // the RWSTORAGE privilege on a resource if the resource is not a storage handler : // URI. Refer to RangerCatalogdAuthorizationManager#createGrantRevokeRequest() for : // further details. : for (TPrivilegeLevel privilege: allExcept(TPrivilegeLevel.RWSTORAGE)) { I exclude TPrivilegeLevel.RWSTORAGE because we do not ask Ranger service to grant the RWSTORAGE privilege on a resource if the resource is not a storage handler URI. Refer to RangerCatalogdAuthorizationManager#createGrantRevokeRequest() for further details. http://gerrit.cloudera.org:8080/#/c/17640/12/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@1220 PS12, Line 1220: // We exclude TPrivilegeLevel.RWSTORAGE because we do not ask Ranger service to grant : // the RWSTORAGE privilege on a resource if the resource is not a storage handler : // URI. Refer to RangerCatalogdAuthorizationManager#createGrantRevokeRequest() for : // further details. : for (TPrivilegeLevel privilege: allExcept(TPrivilegeLevel.RWSTORAGE)) { I exclude TPrivilegeLevel.RWSTORAGE because we do not ask Ranger service to grant the RWSTORAGE privilege on a resource if the resource is not a storage handler URI. Refer to RangerCatalogdAuthorizationManager#createGrantRevokeRequest() for further details. -- To view, visit http://gerrit.cloudera.org:8080/17640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7936e1d8c48696169f7ad7ad92abe44a26eea3c4 Gerrit-Change-Number: 17640 Gerrit-PatchSet: 12 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 02 Nov 2022 00:16:18 +0000 Gerrit-HasComments: Yes
