Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 )
Change subject: IMPALA-9488: Add metrics for EC reads ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/19178/13/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/19178/13/be/src/exec/hdfs-scan-node-base.h@94 PS13, Line 94: /// Splits (i.e. raw byte ranges) for this file, assigned to this scan node. : std::vector<io::ScanRange*> sp > I had that in mind putting it here, but wouldn't hurt to move it further do Done http://gerrit.cloudera.org:8080/#/c/19178/13/tests/query_test/test_io_metrics.py File tests/query_test/test_io_metrics.py: http://gerrit.cloudera.org:8080/#/c/19178/13/tests/query_test/test_io_metrics.py@62 PS13, Line 62: nation_data_file_length = 2199 > Ack Done -- To view, visit http://gerrit.cloudera.org:8080/19178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb06bac9dea4b632621653d2935e9a7b2dc81341 Gerrit-Change-Number: 19178 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:24:03 +0000 Gerrit-HasComments: Yes
