Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19204 )
Change subject: IMPALA-11704: Delay hdfsOpenFile with data cache ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19204/2/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/19204/2/tests/common/skip.py@128 PS2, Line 128: scheduling = pytest.mark.skipif( : not (IS_HDFS or IS_OZONE) or IS_EC or pytest.config.option.testing_remote_cluster, : reason="Test is tuned for scheduling decisions made on a 3-node HDFS minicluster " : "with no EC") > What do we know about the other tests that use this skip? Would they work o I manually verified all the tests that use this flag also work with Ozone. I have follow-up plans - IMPALA-11697 - to review some of the other HDFS-specific skip flags I had previously overlooked. These depend on a 3-node minicluster, but don't seem to be particularly sensitive to block size. http://gerrit.cloudera.org:8080/#/c/19204/2/tests/custom_cluster/test_data_cache.py File tests/custom_cluster/test_data_cache.py: http://gerrit.cloudera.org:8080/#/c/19204/2/tests/custom_cluster/test_data_cache.py@38 PS2, Line 38: if cls.exploration_strategy() != 'exhaustive': These tests take <1 minute to run. I'm not sure why they're guarded by exhaustive, but that means they're not run regularly with EC or Ozone. -- To view, visit http://gerrit.cloudera.org:8080/19204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9429a41fb16de27ccb57730203f95559df0dbfb6 Gerrit-Change-Number: 19204 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 04 Nov 2022 22:33:47 +0000 Gerrit-HasComments: Yes
