Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 )
Change subject: IMPALA-11606: add 'untracked memory' metric ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19029/8/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/19029/8/be/src/runtime/mem-tracker.cc@272 PS8, Line 272: bytes_untracked nit: "bytes-untracked" fits more with the other metric names. http://gerrit.cloudera.org:8080/#/c/19029/8/be/src/runtime/mem-tracker.cc@396 PS8, Line 396: lock_guard<SpinLock> l(child_trackers_lock_); Do you have chance to test this in a busy cluster? Not sure if crawling the metrics every seconds or 0.5s will impact normal workload due to acquiring this lock. -- To view, visit http://gerrit.cloudera.org:8080/19029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib16e00109d732f759c96c7a967eb1cc32124a03f Gerrit-Change-Number: 19029 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 00:16:50 +0000 Gerrit-HasComments: Yes
