Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19214 )
Change subject: WIP IMPALA-7969: Always admit trivial queries immediately ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19214/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19214/1//COMMIT_MSG@21 PS1, Line 21: Need some thinking on the definition of tirvial query : - Any other cases can be trivial queries? : - Any case that we don't want but allows for immediate admission in : this patch? > I think coordinator only queries could also skip admission controller's que Would think the following check will also incorporate the trivial queries such as `select 1` and 'select * from table limit 0` https://github.com/apache/impala/blob/master/be/src/scheduling/scheduler.h#L78 -- To view, visit http://gerrit.cloudera.org:8080/19214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a729764e3055d7eb11900c96c82ff53eb261f91 Gerrit-Change-Number: 19214 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 02:45:24 +0000 Gerrit-HasComments: Yes
