Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 26: (5 comments) http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212 PS26, Line 212: kudu > nit: Kudu Done http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@212 PS26, Line 212: statement is different > nit: statements are different. Done http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@152 PS26, Line 152: // create RangePartition > IMPALA-11430 added support for custom hash partition specification at the r Thanks for your review! The version of Kudu that Impala reference is 956093dd9d. The getRangesWithHashSchemas() in current Kudu version is not public. https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java#L180 Bump Kudu version to 856fa3404b can resolve. I'll try. http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@186 PS26, Line 186: public > nit: change to private Done http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: http://gerrit.cloudera.org:8080/#/c/18729/26/fe/src/main/java/org/apache/impala/util/KuduUtil.java@504 PS26, Line 504: k > nit: Kudu Done -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 26 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 10:34:07 +0000 Gerrit-HasComments: Yes
