Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19223 )
Change subject: IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns' ...................................................................... IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns' In the 'FileMetadataUtils::AddIcebergColumns' method, when the slot is a virtual column, it should be skipped directly. That may affect that when we query the Iceberg v2 table (the first column is a partition column of bool type), wrong position-delete result is given. Testing: - Add e2e tests - Locally tested the result of The Position-based Iceberg tables Change-Id: I58faf3df6ae8a5bcabb1d2ac9f11a6fbcd74bc24 Reviewed-on: http://gerrit.cloudera.org:8080/19223 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/file-metadata-utils.cc A testdata/workloads/functional-query/queries/QueryTest/iceberg-virtual-columns.test M tests/query_test/test_iceberg.py 3 files changed, 44 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58faf3df6ae8a5bcabb1d2ac9f11a6fbcd74bc24 Gerrit-Change-Number: 19223 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
