Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 )
Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@179 PS6, Line 179: new FunctionName(hiveFn_.getDbName(), hiveFn_.getFunctionName()), new HdfsUri(jarUri), symbolName); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@293 PS6, Line 293: throw new CatalogException("Unsupported primitive category: " + primitiveCategory); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java: http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java@99 PS6, Line 99: public HiveGenericJavaFunction createSpecialization(ScalarFunction fn, Type[] paramTypes) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/util/FunctionUtils.java File fe/src/main/java/org/apache/impala/util/FunctionUtils.java: http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/util/FunctionUtils.java@90 PS6, Line 90: private static Function resolveNonGenericFunctions(Iterable<Function> fns, Function desc, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/util/FunctionUtils.java@111 PS6, Line 111: // If the descriptor is generic, then this was called by a DDL statement instead of a line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/util/FunctionUtils.java@117 PS6, Line 117: LOG.info("Failed to match generic UDF: " + desc.functionName().toString() + " error: " + ex.getMessage()); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java File fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java: http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java@57 PS6, Line 57: public HiveJavaFunction createSpecialization(ScalarFunction fn, Type[] paramTypes) throws CatalogException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/19177/6/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19177/6/tests/query_test/test_udfs.py@348 PS6, Line 348: e flake8: E501 line too long (101 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/19177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d402784fa91d1256f5d57fa16ac49728447c8 Gerrit-Change-Number: 19177 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 17:13:52 +0000 Gerrit-HasComments: Yes
