Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19228 )
Change subject: IMPALA-11704: (Addendum) fix crash on open for HDFS cache ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19228/2/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/19228/2/be/src/runtime/io/hdfs-file-reader.cc@a68 PS2, Line 68: The alternative to this would be changing CachedFile to open the file if not already open, but the inversion of control here always made me somewhat nervous. I think making the argument to Open more consistent with the action that results makes it easier to reason about. -- To view, visit http://gerrit.cloudera.org:8080/19228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741488d6195e586917de220a39090895886a2dc5 Gerrit-Change-Number: 19228 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 18:44:46 +0000 Gerrit-HasComments: Yes
