Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 )
Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks good. One question on getting the meta-data from meta-provider cache. What happen when the cache is updated during the use phase of the cached data. Any work needed on the client side? http://gerrit.cloudera.org:8080/#/c/19234/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19234/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@122 PS1, Line 122: warmupCache nit. May name it as warmupMetaProviderCache() to make it clear. -- To view, visit http://gerrit.cloudera.org:8080/19234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac28224b2b6d67725eeb17f3e9d813ba622edb43 Gerrit-Change-Number: 19234 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Sun, 13 Nov 2022 15:06:55 +0000 Gerrit-HasComments: Yes
