Daniel Becker has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/19236 )

Change subject: IMPALA-11719: Inconsistency in printing NULL values
......................................................................

IMPALA-11719: Inconsistency in printing NULL values

NULL values are printed as "NULL" if they are top level or in
collections, but as "null" in structs. We should print collections and
structs in JSON form, so it should be "null" in collections, too. Hive
also follows the latter (correct) approach.

This commit changes the printing of NULL values to "null" in
collections.

Testing:
 - Modified the tests to expect "null" instead of "NULL" in collections.

Change-Id: Ie5e7f98df4014ea417ddf73ac0fb8ec01ef655ba
---
M be/src/runtime/raw-value.cc
M 
testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test
M 
testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test
M 
testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion.test
M 
testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_struct_in_select_list.test
M 
testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test
M 
testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-select-list.test
7 files changed, 67 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/19236/3
--
To view, visit http://gerrit.cloudera.org:8080/19236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie5e7f98df4014ea417ddf73ac0fb8ec01ef655ba
Gerrit-Change-Number: 19236
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>

Reply via email to