Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19227 )
Change subject: IMPALA-11659: Avoid statestored sending the host stats to executors ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19227/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/19227/2/be/src/scheduling/admission-controller.cc@667 PS2, Line 667: FLAGS_is_coordinator This is also used in AdmissiondEnv::Init() in admissiond which has FLAGS_is_coordinator = false. We should only add the prefix when FLAGS_is_executor && !FLAGS_is_coordinator http://gerrit.cloudera.org:8080/#/c/19227/2/be/src/scheduling/admission-controller.cc@667 PS2, Line 667: TOPIC_KEY_POOL_PREFIX I think ideally executors don't need the updates of pool stats as well. There is a TODO added by Csaba: https://gerrit.cloudera.org/c/15793/3/be/src/runtime/exec-env.cc#287 However, the current implementation relies on the "updates" to add pool names to pool_stats_: https://github.com/apache/impala/blob/86fdbfcc995a22a5836c6625fd5c86080fa7764a/be/src/scheduling/admission-controller.cc#L1649 https://github.com/apache/impala/blob/86fdbfcc995a22a5836c6625fd5c86080fa7764a/be/src/scheduling/admission-controller.cc#L2150 Executors only update the reserved mem of pools in pool_stats_ and send updates for them: https://github.com/apache/impala/blob/86fdbfcc995a22a5836c6625fd5c86080fa7764a/be/src/scheduling/admission-controller.cc#L1940-L1950 It's ok since the pool stats are relatively smaller then the host stats. -- To view, visit http://gerrit.cloudera.org:8080/19227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I293c63e71c587b0b217f7b13c1931034ce390f62 Gerrit-Change-Number: 19227 Gerrit-PatchSet: 2 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 08:12:42 +0000 Gerrit-HasComments: Yes
