Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 )
Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication ...................................................................... Patch Set 3: (3 comments) Quick comments http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@169 PS3, Line 169: # ======================= Interim Kerberos support for DWX =========================== Maybe say what you are assuming rather than mentioning DWX which is not open source. http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@176 PS3, Line 176: EXTRA_ARGS=() What is EXTRA_ARGS here? How is it used? http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@180 PS3, Line 180: EXTRA_ARGS+=("-keytab_file=${SERVICE_KEYTAB}" "-principal=${SERVICE_PRINCIPAL}") These look weird, why aren't they --principal and --keytab-file? -- To view, visit http://gerrit.cloudera.org:8080/19248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd Gerrit-Change-Number: 19248 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Kreiner <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 17:19:03 +0000 Gerrit-HasComments: Yes
