Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19242 )

Change subject: IMPALA-11676: Prettify asf-site docs
......................................................................


Patch Set 2:

(1 comment)

Thank you for the reviews Zoltan and Xiang Yang!

Yes, the licenses had to be sorted out, the nav.css was actually replaced by 
the dita-ot-doc.css I just accidentally left it there.

The verify build was failing because of the licenses as well.

http://gerrit.cloudera.org:8080/#/c/19242/1/docs/build-doc.sh
File docs/build-doc.sh:

http://gerrit.cloudera.org:8080/#/c/19242/1/docs/build-doc.sh@23
PS1, Line 23: [--pretty]"
> nit: optional args are usually put into [], not <>
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9621cb0abaa7fd9bf445da08440c0f6a9788180
Gerrit-Change-Number: 19242
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 16 Nov 2022 09:21:16 +0000
Gerrit-HasComments: Yes

Reply via email to