Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19252 )

Change subject: [IMPALA-11728] Set fallback database for functions
......................................................................


Patch Set 1:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/19252/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/19252/1/tests/common/impala_test_suite.py@857
PS1, Line 857: r
flake8: F706 'return' outside function


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py
File tests/custom_cluster/test_fallback_db_for_functions.py:

http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@24
PS1, Line 24: from ImpalaService import ImpalaHiveServer2Service
flake8: F401 'ImpalaService.ImpalaHiveServer2Service' imported but unused


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@27
PS1, Line 27: class TestFallbackDbForFunctions(CustomClusterTestSuite, 
HS2TestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@45
PS1, Line 45:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@45
PS1, Line 45:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@46
PS1, Line 46: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/custom_cluster/test_fallback_db_for_functions.py@49
PS1, Line 49:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/19252/1/tests/metadata/test_ddl.py@20
PS1, Line 20:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19252/1/tests/metadata/test_ddl.py@20
PS1, Line 20: import pytest
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/19252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5
Gerrit-Change-Number: 19252
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 17 Nov 2022 08:53:14 +0000
Gerrit-HasComments: Yes

Reply via email to