Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19261 )
Change subject: IMPALA-11722: Wrong error message when unsupported complex type comes from * expression ...................................................................... Patch Set 1: (3 comments) Seems good, a few remarks. http://gerrit.cloudera.org:8080/#/c/19261/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19261/1//COMMIT_MSG@9 PS1, Line 9: Adds the missing check for unsupported struct fields when SlotRef I think it's a good idea to describe the problem, perhaps by copying the relevant parts of the text from the Jira issue. http://gerrit.cloudera.org:8080/#/c/19261/1/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/19261/1/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@205 PS1, Line 205: have Nit: has. http://gerrit.cloudera.org:8080/#/c/19261/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/19261/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1105 PS1, Line 1105: AnalysisError("select * from functional_parquet.binary_in_complex_types", ctx, Did it fail before this commit? We can still add it if it didn't, just curious. -- To view, visit http://gerrit.cloudera.org:8080/19261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43ffe5d56740b36c93cf4401be871377d3168a4c Gerrit-Change-Number: 19261 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 21 Nov 2022 13:03:36 +0000 Gerrit-HasComments: Yes
