Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19264 )
Change subject: IMPALA-11738: Hide symbols from compression libraries for libfesupport.so ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19264/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19264/2/be/src/service/CMakeLists.txt@62 PS2, Line 62: # TODO: This should also hide most other symbols as a precaution. > Do you know what libraries we do need? We could try `--exclude-libs ALL`. When I use --exclude-libs=ALL, the frontend tests fail. I do want to narrow this down to only expose the symbols we need. I know Kudu does that for the kudu_client, so it's just a matter of figuring it all out. I'll file a JIRA for that. -- To view, visit http://gerrit.cloudera.org:8080/19264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55bda6899044ff2ad98134f5954df83f3e10a5cc Gerrit-Change-Number: 19264 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 22 Nov 2022 19:19:50 +0000 Gerrit-HasComments: Yes
