Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 11: Code-Review+1 (2 comments) Still some comments on the commit message, otherwise looks great. http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19252/7//COMMIT_MSG@16 PS7, Line 16: qualified. > I added four test case descriptions. Sorry, I didn't mean it this way, but simply adding sql queries to the commit message to show this feature can be used , so that someone who wants to use will not need to read the tests. http://gerrit.cloudera.org:8080/#/c/19252/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19252/11//COMMIT_MSG@9 PS11, Line 9: Current nit: currently -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 11 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Wed, 23 Nov 2022 09:02:39 +0000 Gerrit-HasComments: Yes
