[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19274 )

Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 
tables when runtime filters are applied
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

LGTM!
One minor tip for the cause of the test failure.

http://gerrit.cloudera.org:8080/#/c/19274/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test:

http://gerrit.cloudera.org:8080/#/c/19274/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test@541
PS1, Line 541: 2020-01-01 10:00:00
I checked the cause of the test failure.
Table 'functional_parquet.iceberg_v2_partitioned_position_deletes' and Table 
'functional_parquet.iceberg_partitioned' have different parquet metadata, the 
parquet data footer of 'functional_parquet.iceberg_partitioned' is 'event_time: 
TIMESTAMP(MICROS,/*with_timezone*/true)', maybe we need to SET 'SET 
TIMEZONE='Europe/Budapest' before exec the sql.



--
To view, visit http://gerrit.cloudera.org:8080/19274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43f3e0a4df7c1ba6d8ea61410b570d8cf7b31ad3
Gerrit-Change-Number: 19274
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Comment-Date: Thu, 24 Nov 2022 05:39:20 +0000
Gerrit-HasComments: Yes

Reply via email to