Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19279 )
Change subject: IMPALA-11744: Table mask view should reserve the original column order in Hive ...................................................................... Patch Set 1: (4 comments) > I also wonder if the scope of the problem is with column masking views only > or not. Can you please double check? That's a good question! The modified method TableRef#getColumns() (now names as TableRef#getSelectedColumnsInHiveOrder()) is only used in Analyzer#resolveTableMask() to create TableMask. The problem only exists in the scope where TableMask#getRequiredColumns() is used. Those are where we apply column masking or row filtering policies. The problem won't impact other use cases. http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@21 PS1, Line 21: tbl > nit. tbl; Done http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@22 PS1, Line 22: to be > nit. with Done http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@31 PS1, Line 31: makes STAR be expanded > nit. This incorrectly expands the STAR as "b, a, c" ... Done http://gerrit.cloudera.org:8080/#/c/19279/1/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/19279/1/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@560 PS1, Line 560: Hive > nit. May add a comment here to indicate the Hive order is the logically def Sure, this is an override. Copied the comments from FeTable#getColumnsInHiveOrder() to the method of the base class (TableRef#getColumnsInHiveOrder()). -- To view, visit http://gerrit.cloudera.org:8080/19279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic83d78312b19fa2c5ab88ac4f359bfabaeaabce6 Gerrit-Change-Number: 19279 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 26 Nov 2022 05:52:04 +0000 Gerrit-HasComments: Yes
