Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/19252/15/fe/src/main/java/org/apache/impala/analysis/FunctionName.java File fe/src/main/java/org/apache/impala/analysis/FunctionName.java: http://gerrit.cloudera.org:8080/#/c/19252/15/fe/src/main/java/org/apache/impala/analysis/FunctionName.java@128 PS15, Line 128: preferBuiltinsDb > Is it possible that 'preferBuiltinsDb' is false but fallbackDbContainsFn(an Yes, the query option doesn't take effect to CREATE/DROP FUNCTION statements. The source of this requirement is that the user-defined function only needs to be created once, and it takes effect on all databases. After setting FALLBACK_DB_FOR_FUNCTIONS, the queries use functions without specified database. For CREATE/DROP FUNCTION statements. I did not find the required scene. What do you think? http://gerrit.cloudera.org:8080/#/c/19252/15/fe/src/main/java/org/apache/impala/analysis/FunctionName.java@145 PS15, Line 145: FeDb feDb = analyzer.getDb(dbName, false); > To address Csaba's concern at https://gerrit.cloudera.org/c/19252/15/tests/ Thanks for your very useful advice. I changed it and added the test. -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 15 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 08:37:45 +0000 Gerrit-HasComments: Yes
