Gergely Fürnstáhl has uploaded a new patch set (#8). (
http://gerrit.cloudera.org:8080/19290 )
Change subject: IMPALA-11758: Fixed error detection for usage of reserved words.
......................................................................
IMPALA-11758: Fixed error detection for usage of reserved words.
Fixed the control flow of checking whether the parsing failed on the
usage of a reserved word where an identifier was expected. Added a hint
to the error message on how to fix the query.
Query: create database iceberg
ERROR: ParseException: Syntax error in line 1:
create database iceberg
^
Encountered: ICEBERG
Expected: DEFAULT, EXTENDED, FORMATTED, IF, IDENTIFIER
Hint: reserved words have to be escaped when used as an identifier, e.g.
`iceberg`
CAUSED BY: Exception: Syntax error
Testing:
- Added new tests to test_reserved_words_version.py
- Adjusted ParserTests
- Built docs
Change-Id: I9605d80a25ff878d12f6ca2ebb99ac26298d8efa
---
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/custom_cluster/test_reserved_words_version.py
4 files changed, 50 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/19290/8
--
To view, visit http://gerrit.cloudera.org:8080/19290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9605d80a25ff878d12f6ca2ebb99ac26298d8efa
Gerrit-Change-Number: 19290
Gerrit-PatchSet: 8
Gerrit-Owner: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
