Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 13: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19181/11/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19181/11/be/src/codegen/llvm-codegen.cc@932 PS11, Line 932: fn.binary_type == TFunctionBinaryType::NATIVE > Did an investigation, the broken_builtin, such as from_utc_timestamp and mo Thanks for adding the test! http://gerrit.cloudera.org:8080/#/c/19181/11/tests/custom_cluster/test_codegen_cache.py File tests/custom_cluster/test_codegen_cache.py: http://gerrit.cloudera.org:8080/#/c/19181/11/tests/custom_cluster/test_codegen_cache.py@51 PS11, Line 51: test_codegen_cache_int_col > It could need some work to change. But the tests are running in exhaustive Ack -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 13 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:30:29 +0000 Gerrit-HasComments: Yes
