Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19312 )
Change subject: IMPALA-11767: Catch exceptions for invalid paths in Hudi search ...................................................................... Patch Set 1: Code-Review+2 (2 comments) LGTM http://gerrit.cloudera.org:8080/#/c/19312/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19312/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11767: Catch exceptions for invalid paths in Hudi search Nit: "Ignore exceptions for invalid paths in Hudi search" http://gerrit.cloudera.org:8080/#/c/19312/1/fe/src/main/java/org/apache/impala/util/HudiUtil.java File fe/src/main/java/org/apache/impala/util/HudiUtil.java: http://gerrit.cloudera.org:8080/#/c/19312/1/fe/src/main/java/org/apache/impala/util/HudiUtil.java@41 PS1, Line 41: LOG.debug("Unable to check Hudi path", e); Does the exception contain the dodgy file path? I think it does as we saw it in the test failures. If it does not we could include f.getPath() in the log message. -- To view, visit http://gerrit.cloudera.org:8080/19312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecc572ce78b13f7ddc177ad371fcf3048241620d Gerrit-Change-Number: 19312 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:20:31 +0000 Gerrit-HasComments: Yes
