Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19130 )
Change subject: IMPALA-11654: fix comparison unit mismatch in Statestore::MonitorSubscriberHeartbeat ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19130/1/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/19130/1/be/src/statestore/statestore.cc@1022 PS1, Line 1022: if (subscriber.second->SecondsSinceHeartbeat() * 1000 : > FLAGS_heartbeat_monitoring_frequency_ms) { : inactive_subscribers.push_back(subscriber.second->id()); : } > how about adding a test for it? +1. I think we can improve TestStatestore::test_slow_subscriber() in tests/statestore/test_statestore.py to verify there is a WARNING log of "Slow subscribers". impala_test_suite.py has assert_impalad_log_contains() and assert_catalogd_log_contains() for verifying logs. We can add one for statestore as well. -- To view, visit http://gerrit.cloudera.org:8080/19130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f487e1879c09b4b50addca3c689f63150f7104d Gerrit-Change-Number: 19130 Gerrit-PatchSet: 1 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 03 Dec 2022 01:38:34 +0000 Gerrit-HasComments: Yes
