Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 23: (1 comment) > Patch Set 22: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8853/ I think the failure is unrelated. Filed IMPALA-11775 to track it. http://gerrit.cloudera.org:8080/#/c/19252/23/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/19252/23/be/src/service/query-options.cc@1041 PS23, Line 1041: .c_str() Don't need c_str() here. __set_fallback_db_for_functions() accept a "const std::string&". We use 'value' directly in other string options, e.g. https://github.com/apache/impala/blob/63a344066997c5e4695cbdffeb5bf9a17e532d4b/be/src/service/query-options.cc#L259 https://github.com/apache/impala/blob/63a344066997c5e4695cbdffeb5bf9a17e532d4b/be/src/service/query-options.cc#L304 -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 23 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 01:34:47 +0000 Gerrit-HasComments: Yes
