Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19186 )
Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables ...................................................................... IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables IMPALA-9822 adds a warning when the customized row format delimiters in the CreateTable statement are ignored on non-TEXT and non-SEQUENCE tables. However, the warning also shows up for TEXT/SEQUENCE tables. The cause is an incorrect check in the table format that all formats match the condition. This patch fixes the condition and adds tests to verify that no warnings show up in such cases. Currently the test methods (e.g. AnalyzesOk) only check expected warning messages when provided. If the provided expected message is null, they just skip checking the warnings. This patch adds methods like AnalyzesOkWithoutWarnings to assure no warnings are generated. Tests - Run FE tests Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Reviewed-on: http://gerrit.cloudera.org:8080/19186 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/common/FrontendFixture.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java 5 files changed, 56 insertions(+), 23 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Gerrit-Change-Number: 19186 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
