Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 )
Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/19194/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/19194/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2986 PS11, Line 2986: requires SELECT : // (or higher) privilege on the database. This doesn't seem exactly right anymore. http://gerrit.cloudera.org:8080/#/c/19194/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2995 PS11, Line 2995: .ok(onDatabase("functional", viewMetadataPrivileges())) Shouldn't this fail if the privilege is not SELECT? http://gerrit.cloudera.org:8080/#/c/19194/11/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19194/11/tests/authorization/test_ranger.py@1405 PS11, Line 1405: admin_client.execute( : "grant select on database {0} to user {1}".format( : unique_database, test_user), user=ADMIN) : self._refresh_authorization(admin_client, refresh_stmt) The test could be extended to grant another privilege first (e.g. insert), and then select on the udf -- To view, visit http://gerrit.cloudera.org:8080/19194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e58ba30545ce169786aac279b00c8f6e09ae740 Gerrit-Change-Number: 19194 Gerrit-PatchSet: 11 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 09:13:59 +0000 Gerrit-HasComments: Yes
